Correct post-update action comment on claims from closed chans #3985
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-`ChannelMonitorUpdate` completion action immediately as we didn't actually track async `ChannelMonitorUpdate`s to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated. Thus, here we update the comment, for the easiest close on a major feature issue ever. Fixes lightningdevkit#2355.
|
I've assigned @valentinewallace as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02%
==========================================
Files 174 174
Lines 124201 124201
Branches 124201 124201
==========================================
- Hits 110472 110459 -13
- Misses 11251 11261 +10
- Partials 2478 2481 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-
ChannelMonitorUpdatecompletion action immediately as we didn't actually track asyncChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes #2355.