Skip to content

[LSP5] Change notification dooldown time to 1 minute, alsp update docs #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinsaposnic
Copy link
Contributor

LSPS5 follow ups. Addressing comments #3975 (review) and #3975

changes:

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 7, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@martinsaposnic martinsaposnic mentioned this pull request Aug 7, 2025
18 tasks
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.92%. Comparing base (c8450bf) to head (24712cf).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3994      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.01%     
==========================================
  Files         174      174              
  Lines      124538   124538              
  Branches   124538   124538              
==========================================
- Hits       110757   110747      -10     
  Misses      11291    11291              
- Partials     2490     2500      +10     
Flag Coverage Δ
fuzzing 22.18% <0.00%> (ø)
tests 88.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase now.

@tnull tnull removed the request for review from joostjager August 7, 2025 17:30
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from ecf258c to 43eeb48 Compare August 7, 2025 17:37
@martinsaposnic
Copy link
Contributor Author

rebase done!

@martinsaposnic martinsaposnic requested a review from tnull August 7, 2025 17:39
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from 43eeb48 to 24712cf Compare August 7, 2025 17:42
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned elsewhere, we might need a spec change in parallel to this.

Also, nit: 'LSP5', 'dooldown' and 'alsp' typos in the commit message (which could otherwise also use a bit more detail what this change is and why we want it).

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants