Skip to content

Conversation

TheBlueMatt
Copy link
Collaborator

An earlier version of 92f1961 required tracking the funding txo when we initialize splicing, but it is now unused, so can be dropped.

As pointed out at #4019 (comment)

An earlier version of 92f1961
required tracking the funding txo when we initialize splicing, but
it is now unused, so can be dropped.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 29, 2025

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot ldk-reviews-bot requested a review from tnull August 29, 2025 14:04
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.74%. Comparing base (2150f24) to head (5f83e54).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4035      +/-   ##
==========================================
+ Coverage   88.73%   88.74%   +0.01%     
==========================================
  Files         176      176              
  Lines      128891   128891              
  Branches   128891   128891              
==========================================
+ Hits       114369   114387      +18     
+ Misses      11926    11910      -16     
+ Partials     2596     2594       -2     
Flag Coverage Δ
fuzzing 21.92% <ø> (ø)
tests 88.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, although if/how we should do tracking of channel-related onchain transaction is still an ongoing, but separate discussion.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@tnull tnull merged commit 26639f1 into lightningdevkit:main Sep 1, 2025
37 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants