Test commitment broadcast during different stages of a splice #4068
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
wpaulino
force-pushed
the
test-splice-commitment-broadcast
branch
from
527c78a to
7456483
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4068 +/- ##
==========================================
- Coverage 88.71% 88.70% -0.01%
==========================================
Files 177 177
Lines 133245 133404 +159
Branches 133245 133404 +159
==========================================
+ Hits 118202 118331 +129
- Misses 12331 12361 +30
Partials 2712 2712
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @TheBlueMatt @jkczyz! This PR has been waiting for your review. |
1 similar comment
|
🔔 1st Reminder Hey @TheBlueMatt @jkczyz! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @TheBlueMatt @jkczyz! This PR has been waiting for your review. |
There was a problem hiding this comment.
Code changes LGTM, I'll leave @jkczyz to review the tests in more detail.
| OnchainEvent::FundingSpendConfirmation { commitment_tx_to_counterparty_output, .. } => { | ||
| self.funding_spend_confirmed = Some(entry.txid); | ||
| self.confirmed_commitment_tx_counterparty_output = commitment_tx_to_counterparty_output; | ||
| if self.alternative_funding_confirmed.is_none() && !self.pending_funding.is_empty() { |
There was a problem hiding this comment.
When would we get this event when self.alternative_funding_confirmed is Some? Is there some re-org case that could cause this?
There was a problem hiding this comment.
We always get a FundingSpendConfirmation when we see a commitment transaction confirm, alternative_funding_confirmed just tells us if a funding transaction other than the one tracked by self.funding is the one that confirmed instead.
wpaulino
force-pushed
the
test-splice-commitment-broadcast
branch
from
7456483 to
35c37cb
Compare
While we did consider the pending HTLCs when generating the signatures, we did not include them in the resulting `commitment_signed` message sent because we assumed it was only used within a dual-funding context where there are no pending HTLCs.
This ensures a valid commitment transaction is broadcast according to the different stages of a splice: 1. Negotiated but unconfirmed 2. Confirmed but not locked 3. Locked
When adding support for emitting these events in the channel monitor, we only covered the case where one of the splice transaction candidates confirmed. We also need to emit an event when none of them can confirm due to a commitment transaction confirming (and no longer under reorg risk) for the pre-splice funding.
wpaulino
force-pushed
the
test-splice-commitment-broadcast
branch
from
35c37cb to
aa912ce
Compare
|
CI was failing due to not being rebased on #3984 |
This also caught a bug where we weren't including signatures for pending HTLCs in the initial
commitment_signedfor the splice.Depends on #4054.