Fix crash when a claim tx has some non-witness inputs. #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logger which decides what to refer to an on-chain claim tx was assuming that all inputs would have a witness. While this was fine for the one-input case, it broke the fuzzer which was connecting a consensus-invalid transaction. Further, in the case we have multiple inputs, some may not have a witness, which we shouldn't crash on. This fixes 9df0250.
TheBlueMatt
force-pushed
the
2020-01-fix-tx-log
branch
from
a6b97fc to
6596efa
Compare
ariard
reviewed
Jan 17, 2020
| for inp in &self.0.input { | ||
| if !inp.witness.is_empty() { | ||
| if inp.witness.last().unwrap().len() == 133 { write!(f, "preimage tx")?; break } | ||
| else if inp.witness.last().unwrap().len() == 138 { write!(f, "timeout tx")?; break } |
There was a problem hiding this comment.
need to adapter printer here, we may aggregate tx and so a tx may be both preimage + timeout, so "Broadcast onchain preimage-timeout-preimage-... tx", dunno if it's clear enough for reader
|
Part of #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger which decides what to refer to an on-chain claim tx was
assuming that all inputs would have a witness. While this was fine
for the one-input case, it broke the fuzzer which was connecting a
consensus-invalid transaction. Further, in the case we have multiple
inputs, some may not have a witness, which we shouldn't crash on.
This fixes 9df0250.