Skip to content

Trivial Cleanups #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 20, 2020
Merged

Trivial Cleanups #594

merged 5 commits into from
Apr 20, 2020

Conversation

TheBlueMatt
Copy link
Collaborator

A few trivial cleanups, most of them to address new rustc warnings.

@TheBlueMatt
Drop uneccessary indirection in map-updating in 1107ab0
e286afd 
1107ab0 added a Vec of future
updates to apply during a loop, fixing a borrow checker issue that
didn't exist in the merged version of the patch. This simply reverts
that small part of the change.
@TheBlueMatt
Fix new rustc warnings for unnecessary parenthesis
41b3be7
@TheBlueMatt
Concretize some types in fuzz, addressing new rustc warnings
7e0b576
@TheBlueMatt
Drop std::error::Error impl for DecodeError
f5b0663 
It appears to be effectively-deprecated in Rust now, and didn't
really appear to serve a lot of purpose anyway.
@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b9db2ec). Click here to learn what that means.
The diff coverage is n/a.

@TheBlueMatt
Copy link
Collaborator Author

@TheBlueMatt
De-Option<> some fields in ChannelMonitor which are set at init
c89514c 
After we moved the ChannelMonitor creation later during Channel
init, we never went back and cleaned up ChannelMonitor to remove
a number of now-useless Option<>s, so we do that now.
This was referenced Apr 19, 2020
Merged
Closed
valentinewallace
valentinewallace approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup!

@TheBlueMatt TheBlueMatt merged commit 5a2ed03 into lightningdevkit:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinewallace valentinewallace valentinewallace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBlueMatt @valentinewallace