Test remote fee spike buffer violation #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
force-pushed
the
test-remote-fee-spike-buffer-violation
branch
from
25abd8c to
d277eb3
Compare
HTLCs that violate the remote's fee spike buffer should be failed.
valentinewallace
force-pushed
the
test-remote-fee-spike-buffer-violation
branch
from
d277eb3 to
940d7ac
Compare
TheBlueMatt
approved these changes
Jun 27, 2020
| }; | ||
| nodes[1].logger.assert_log("lightning::ln::channel".to_string(), "Attempting to fail HTLC due to fee spike buffer violation".to_string(), 1); | ||
|
|
||
| check_added_monitors!(nodes[1], 2); |
There was a problem hiding this comment.
Not that its really critical, but in general I prefer to check for added monitors right after they get added (ie after the handle_commitment_signed and handle_revoke_and_ack) since it enforces better that those calls succeeded all the way through to generating a monitor update.
There was a problem hiding this comment.
Makes sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for this case that was missing from #577.
Because
channel.send_htlcwould prevent us from sending a payment that violates our fee spike buffer, each message from the HTLC's sender is manually constructed. Hence why the test looks pretty complicated.