Bindings updates for 789 #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly, there's just not really a practical way to map a slice of objects in our current bindings infrastructure - either we take ownership of the underlying objects and move them into a Vec, or we need to leave the original objects in place and have a list of pointers to the Rust objects. Thus, the only practical mapping is to create a slice of references using the pointers we have.
`from_c_conversion_container_new_var` should use var_access when it wishes to access the variable being converted, not `var_name`, but in a few cases it did not. Note that this has no impact on the generated bindings as of this commit.
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 90.82% 90.77% -0.06%
==========================================
Files 44 44
Lines 24282 24283 +1
==========================================
- Hits 22054 22042 -12
- Misses 2228 2241 +13
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Feb 19, 2021
|
Merging with one ACK since the full non-bindings diff is a trivial -3+3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly but surely, bindings updates for PRs are getting smaller and smaller...