Add validate_best_block_header utility #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor synchronize_listeners by pulling out a function returning the validated block header of a BlockSource's best chain tip. This is needed when a node is started from scratch and has no listeners to sync.
TheBlueMatt
approved these changes
Mar 2, 2021
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
=======================================
Coverage 90.73% 90.74%
=======================================
Files 48 48
Lines 25642 25646 +4
=======================================
+ Hits 23267 23272 +5
+ Misses 2375 2374 -1
Continue to review full report at Codecov.
|
ariard
reviewed
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor synchronize_listeners by pulling out a function returning the
validated block header of a BlockSource's best chain tip. This is needed
when a node is started from scratch and has no listeners to sync.