Skip to content

staticaddr: fix withdraw backwards compat #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

hieblmi
Copy link
Collaborator

@hieblmi hieblmi commented Mar 3, 2025

This PR restores a previously removed parameter of ServerWithdrawRequest, TxFeeRate, to allow withdrawing with a fee rate without change.

@hieblmi hieblmi self-assigned this Mar 3, 2025
@hieblmi hieblmi marked this pull request as draft March 3, 2025 13:36
@hieblmi hieblmi force-pushed the fix-withdraw-request-params branch from 3062c00 to c1c809d Compare March 3, 2025 15:17
@hieblmi hieblmi marked this pull request as ready for review March 3, 2025 15:17
@hieblmi hieblmi requested review from bhandras, sputn1ck and starius March 3, 2025 15:18
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given the old protocol is considered unreleased. 👍

@hieblmi hieblmi merged commit e86ccb9 into lightninglabs:master Mar 4, 2025
4 checks passed
@hieblmi hieblmi deleted the fix-withdraw-request-params branch March 4, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants