Bump go to v1.24.6 #1815
Bump go to v1.24.6 #1815
Conversation
In preparation to the next commit which will bump the golang version we want to avoid calling printf with non-constant format strings. This needs to be done as the govet will include a new rule that prohibits exactly that -- calling into printf with non-constant format strings.
Summary of ChangesHello @GeorgeTsagk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update of the Go programming language version to v1.24.6 across the repository. This update is crucial for maintaining compatibility with the latest LND version and is a prerequisite for upcoming feature development. It also includes a minor code adjustment to adhere to a new Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the Go version to v1.24.6 across various configuration files, including Dockerfiles and go.mod files. The changes are consistent and align with the goal of keeping the project's dependencies up-to-date. The modification in internal/test/copy.go to use t.Fatal instead of t.Fatalf with a variable is a proper fix for the new govet rule introduced in Go 1.24. The changes are well-contained and address the stated purpose of the pull request effectively.
Pull Request Test Coverage Report for Build 17979473000Details
💛 - Coveralls |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
Routine golang bump, in preparation for other PRs that depend on latest LND.
LND recently updated to v1.24.6: lightningnetwork/lnd#10167
These tapd PRs bump the LND dependency, and will require this repo to update its golang version:
Govet: new printf rule
With go v1.24.6 a new govet rule was added that disallows calling printf with non-constant format strings. Thankfully we didn't have many occurrences of this in tapd. The first commit takes care of any call sites that relied on this behavior.