build: update to btcec/v2 and btcd/btcutil #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we update our deps to use the new `btcec/v2` APIs as well as point to the new `btcd/btcutil` repo. Along the way, we get a ~8% speed up in packet construction, and a ~9% speed up in packet processing due to the more optimized EC routines that `btcec/v2` uses. Benchmark run with the new changes: ``` goos: darwin goarch: amd64 pkg: github.com/lightningnetwork/lightning-onion cpu: VirtualApple @ 2.50GHz BenchmarkPathPacketConstruction-8 366 3260221 ns/op 174541 B/op 1411 allocs/op BenchmarkProcessPacket-8 4926 247395 ns/op 21059 B/op 68 allocs/op PASS ``` Benchmark run with the old code: ``` goos: darwin goarch: amd64 pkg: github.com/lightningnetwork/lightning-onion cpu: VirtualApple @ 2.50GHz BenchmarkPathPacketConstruction-8 332 3522599 ns/op 170336 B/op 1410 allocs/op BenchmarkProcessPacket-8 4425 270806 ns/op 22166 B/op 99 allocs/op PASS ```
Turns out in practice, the 27 hop limit is actually _too large_, so we fall back to the old 20 hop limit for now. We'll want to circle back and emperically derive the _true_ hop limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we update our deps to use the new
btcec/v2APIs as wellas point to the new
btcd/btcutilrepo.Along the way, we get a ~8% speed up in packet construction, and a ~9%
speed up in packet processing due to the more optimized EC routines that
btcec/v2uses.Benchmark run with the new changes:
Benchmark run with the old code: