-
Notifications
You must be signed in to change notification settings - Fork 79
WIP: Scala 2.13 #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Scala 2.13 #138
Conversation
All the tests are successfull in sbt. I only see Symbol deprecation. What is still in progress ? |
The cross-compilation with 2.12 and 2.11 doesn't work yet. See: |
Yes, it's what i realized looking to the CI logs. So we just need to wait for an update of the collection-compat lib if I understand properly ? |
Correct. I hope that this PR fixes it: scala/scala-collection-compat#249 |
collection-compat has been released ! |
Looks like we have to drop Scala 2.11 now. Since libraries like |
@fdietze I am for it |
@fdietze let's drop 2.11 ! |
(CrossVersion.partialVersion(scalaVersion.value) match { | ||
case Some((2, v)) if v >= 12 => | ||
case Some((2, 12)) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have a review on this one.
What is a good approach to handle compiler options when cross-compiling?
fixes #137
(currently blocked by scala/scala-collection-compat#247)