Skip to content

Conversation

fdietze
Copy link
Collaborator

@fdietze fdietze commented Sep 2, 2019

fixes #137

(currently blocked by scala/scala-collection-compat#247)

@mathieuleclaire
Copy link

All the tests are successfull in sbt. I only see Symbol deprecation. What is still in progress ?

@fdietze
Copy link
Collaborator Author

fdietze commented Jan 9, 2020

The cross-compilation with 2.12 and 2.11 doesn't work yet. See:
scala/scala-collection-compat#247
scala/scala-collection-compat#249

@mathieuleclaire
Copy link

Yes, it's what i realized looking to the CI logs. So we just need to wait for an update of the collection-compat lib if I understand properly ?

@fdietze
Copy link
Collaborator Author

fdietze commented Jan 10, 2020

Correct. I hope that this PR fixes it: scala/scala-collection-compat#249
I'll leave another message there.

@mathieuleclaire
Copy link

collection-compat has been released !
https://github.com/scala/scala-collection-compat/releases

@fdietze
Copy link
Collaborator Author

fdietze commented Feb 11, 2020

Looks like we have to drop Scala 2.11 now. Since libraries like acyclic and monocle dropped 2.11 in favor of 2.13:
https://mvnrepository.com/artifact/com.lihaoyi/acyclic
https://mvnrepository.com/artifact/com.github.julien-truffaut/monocle-macro

@fdietze
Copy link
Collaborator Author

fdietze commented Feb 11, 2020

@Voltir @lihaoyi How do you feel about dropping 2.11 support in favor of 2.13?

@Voltir
Copy link
Collaborator

Voltir commented Feb 11, 2020

@fdietze I am for it

@mathieuleclaire
Copy link

@fdietze let's drop 2.11 !

(CrossVersion.partialVersion(scalaVersion.value) match {
case Some((2, v)) if v >= 12 =>
case Some((2, 12)) =>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a review on this one.

What is a good approach to handle compiler options when cross-compiling?

@cornerman cornerman mentioned this pull request Mar 7, 2020
@fdietze fdietze merged commit 91219ca into master Mar 8, 2020
@fdietze fdietze deleted the 2.13 branch March 8, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.13 support
3 participants