Skip to content

Minimal changes to support windows #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dalito
Copy link
Member

@dalito dalito commented May 20, 2025

Only one test failed on Windows due to a file path comparison that was not written to work cross platform.

This PR:

  • fixes the file-comparison to work also on Windows
  • adds running on windows-latest to the main CI file.
  • activates running tests on merging PRs to main.
  • changes the poetry installation to use pipx (as in other linkml-repos)
  • Allows to start action runs manually (via workflow_dispatch)

Note that the tests here may fail when the github-api rate limit is hit.

@dalito dalito force-pushed the windows-support branch from 3b133fc to 68656b5 Compare May 20, 2025 20:34
@dalito dalito requested a review from sujaypatil96 May 20, 2025 20:46
@dalito
Copy link
Member Author

dalito commented May 20, 2025

I cannot re-run the failed job here. It failed due to github-api rate limit.
...either I lack permissions in this repo or re-starting runs requires workflow_dispatch which is only added in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant