tests(schemaview): optimize execution #394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid opening the same schema 9 times for very similar tests. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Silvanoc
force-pushed
the
improve-test-performance
branch
from
184ff54 to
19faa36
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 63.79% 63.79%
=======================================
Files 63 63
Lines 8938 8938
Branches 2584 2584
=======================================
Hits 5702 5702
Misses 2629 2629
Partials 607 607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tiny improvement on changes introduced by @ialarmedalien on this commit, therefore adding him as reviewer. |
|
LGTM. Tag me when you convert the PR to non-draft status so I can approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating
SchemaViewof the same schema 9 times for very similar tests.