refactor: cleanup deadcode EnumDefinitionImpl #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module declaring `EnumDefinitionImpl` in `linkml_runtime/utils/permissiblevalueimply.py` does not appear to be used anywhere. Additionally `EnumDefinitionImpl` already has a declaration in `linkml_runtime/utils/enumerations.py`, which is being used in many places in the code. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
|
Part of refactoring proposed (and implicitly accepted, since silent is consent) in issue linkml/linkml#2371 Keeping it as |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 63.76% 64.45% +0.69%
==========================================
Files 63 62 -1
Lines 8942 8846 -96
Branches 2586 2556 -30
==========================================
Hits 5702 5702
+ Misses 2631 2535 -96
Partials 609 609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module declaring
EnumDefinitionImplinlinkml_runtime/utils/permissiblevalueimply.pydoes not appear to be used anywhere.Additionally
EnumDefinitionImplalready has a declaration inlinkml_runtime/utils/enumerations.py, which is being used in many places in the code.