-
Notifications
You must be signed in to change notification settings - Fork 171
ci: install Cloud Firewall Controller for LKE cluster #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success93 tests passing in 9 suites. Report generated by 🧪jest coverage report action from bb82418 |
j-zimnowoda
approved these changes
May 21, 2025
Ani1357
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
The Linode Cloud Firewall Controller has been released for several months now, and there is no known interference with installing or running the platform. We should by default install it on any LKE cluster that we deploy using our GitHub workflow.
This PR also removes the always silently failing Slack notification task.
🔍 Reviewer Notes
HTTP and HTTPS as provided by typical LKE-hosted services should not be impacted. SSH access to the single nodes is no longer possible, which is the desired effect of the firewall.
In the unlikely event that it is required, the firewall can be disabled or edited manually. Also it is possible to deploy custom rules, as provided here: https://github.com/linode/cloud-firewall-controller/tree/main/examples
🧹 Checklist
N/A