Skip to content

feat: adding ORCS support for kubeflow #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion charts/kubeflow-pipelines/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,16 @@ app.kubernetes.io/managed-by: {{ .Release.Service }}
app.kubernetes.io/name: {{ include "kfp.fullname" . }}
app.kubernetes.io/owner: {{ .Release.Namespace }}
otomi.io/app: {{ include "kfp.fullname" . }}
{{- end }}
{{- end }}

{{- define "kubeflowRegistry" -}}
{{- default "ghcr.io/kubeflow" .Values.global.kubeflowRegistry }}
{{- end }}

{{- define "tfxOssPublicRegistry" -}}
{{- default "gcr.io/tfx-oss-public" .Values.global.tfxOssPublicRegistry }}
{{- end }}

{{- define "mlPipelineRegistry" -}}
{{- default "gcr.io/ml-pipeline" .Values.global.mlPipelineRegistry }}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: ghcr.io/kubeflow/kfp-cache-deployer:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-cache-deployer:{{ .Chart.AppVersion }}
imagePullPolicy: Always
name: main
{{- with .Values.cacheDeployer.resources }}
resources: {{- . | toYaml | nindent 10 }}
{{- end }}
restartPolicy: Always
serviceAccountName: kubeflow-pipelines-cache-deployer-sa
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ spec:
fieldPath: metadata.namespace
- name: WEBHOOK_PORT
value: "8443"
image: ghcr.io/kubeflow/kfp-cache-server:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-cache-server:{{ .Chart.AppVersion }}
imagePullPolicy: Always
securityContext:
allowPrivilegeEscalation: false
Expand Down Expand Up @@ -109,4 +109,4 @@ spec:
- name: webhook-tls-certs
secret:
secretName: webhook-server-tls
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
component: metadata-envoy
spec:
containers:
- image: ghcr.io/kubeflow/kfp-metadata-envoy:{{ .Chart.AppVersion }}
- image: {{ include "kubeflowRegistry" . }}/kfp-metadata-envoy:{{ .Chart.AppVersion }}
name: container
{{- with .Values.metadataEnvoy.resources }}
resources: {{- . | toYaml | nindent 12 }}
Expand All @@ -40,4 +40,4 @@ spec:
capabilities:
drop:
- ALL
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
configMapKeyRef:
key: mysqlPort
name: pipeline-install-config
image: gcr.io/tfx-oss-public/ml_metadata_store_server:1.14.0
image: {{ include "tfxOssPublicRegistry" . }}/ml_metadata_store_server:1.14.0
securityContext:
allowPrivilegeEscalation: false
seccompProfile:
Expand Down Expand Up @@ -85,4 +85,4 @@ spec:
port: grpc-api
timeoutSeconds: 2
serviceAccountName: metadata-grpc-server
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: ghcr.io/kubeflow/kfp-metadata-writer:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-metadata-writer:{{ .Chart.AppVersion }}
securityContext:
allowPrivilegeEscalation: false
seccompProfile:
Expand All @@ -39,4 +39,4 @@ spec:
resources: {{- . | toYaml | nindent 12 }}
{{- end }}
serviceAccountName: kubeflow-pipelines-metadata-writer
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
value: "2"
- name: LOG_LEVEL
value: info
image: ghcr.io/kubeflow/kfp-persistence-agent:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-persistence-agent:{{ .Chart.AppVersion }}
imagePullPolicy: IfNotPresent
securityContext:
allowPrivilegeEscalation: false
Expand Down Expand Up @@ -58,4 +58,4 @@ spec:
audience: pipelines.kubeflow.org
expirationSeconds: 3600
path: persistenceagent-sa-token
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
configMapKeyRef:
key: cronScheduleTimezone
name: pipeline-install-config
image: ghcr.io/kubeflow/kfp-scheduled-workflow-controller:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-scheduled-workflow-controller:{{ .Chart.AppVersion }}
imagePullPolicy: IfNotPresent
securityContext:
allowPrivilegeEscalation: false
Expand All @@ -48,4 +48,4 @@ spec:
resources: {{- . | toYaml | nindent 12 }}
{{- end }}
serviceAccountName: ml-pipeline-scheduledworkflow
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
fieldPath: metadata.namespace
- name: DISABLE_GKE_METADATA
value: "true"
image: ghcr.io/kubeflow/kfp-frontend:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-frontend:{{ .Chart.AppVersion }}
imagePullPolicy: IfNotPresent
securityContext:
allowPrivilegeEscalation: false
Expand Down Expand Up @@ -91,4 +91,4 @@ spec:
- configMap:
name: ml-pipeline-ui-configmap
name: config-volume
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: ghcr.io/kubeflow/kfp-viewer-crd-controller:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-viewer-crd-controller:{{ .Chart.AppVersion }}
imagePullPolicy: Always
securityContext:
allowPrivilegeEscalation: false
Expand All @@ -43,4 +43,4 @@ spec:
resources: {{- . | toYaml | nindent 12 }}
{{- end }}
serviceAccountName: ml-pipeline-viewer-crd-service-account
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
application-crd-id: kubeflow-pipelines
spec:
containers:
- image: ghcr.io/kubeflow/kfp-visualization-server:{{ .Chart.AppVersion }}
- image: {{ include "kubeflowRegistry" . }}/kfp-visualization-server:{{ .Chart.AppVersion }}
imagePullPolicy: IfNotPresent
securityContext:
allowPrivilegeEscalation: false
Expand Down Expand Up @@ -63,4 +63,4 @@ spec:
resources: {{- . | toYaml | nindent 12 }}
{{- end }}
serviceAccountName: ml-pipeline-visualizationserver
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
configMapKeyRef:
name: pipeline-install-config
key: objPort
image: ghcr.io/kubeflow/kfp-api-server:{{ .Chart.AppVersion }}
image: {{ include "kubeflowRegistry" . }}/kfp-api-server:{{ .Chart.AppVersion }}
imagePullPolicy: IfNotPresent
livenessProbe:
exec:
Expand Down Expand Up @@ -181,4 +181,4 @@ spec:
drop:
- ALL
serviceAccountName: ml-pipeline
---
---
4 changes: 2 additions & 2 deletions charts/kubeflow-pipelines/templates/mysql/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
secretKeyRef:
name: kfp-mysql-secret
key: password
image: gcr.io/ml-pipeline/mysql:8.0.26
image: {{ include "mlPipelineRegistry" . }}/mysql:8.0.26
name: ml-pipeline-mysql
ports:
- containerPort: 3306
Expand All @@ -46,4 +46,4 @@ spec:
- name: mysql-persistent-storage
persistentVolumeClaim:
claimName: mysql-pv-claim
---
---
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
- --configmap
- workflow-controller-configmap
- --executor-image
- gcr.io/ml-pipeline/argoexec:v3.4.17-license-compliance
- {{ include "mlPipelineRegistry" . }}/argoexec:v3.4.17-license-compliance
- --namespaced
command:
- workflow-controller
Expand All @@ -32,7 +32,7 @@ spec:
fieldRef:
apiVersion: v1
fieldPath: metadata.name
image: gcr.io/ml-pipeline/workflow-controller:v3.4.17-license-compliance
image: {{ include "mlPipelineRegistry" . }}/workflow-controller:v3.4.17-license-compliance
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down Expand Up @@ -61,4 +61,4 @@ spec:
priorityClassName: workflow-controller
securityContext:
runAsNonRoot: true
serviceAccountName: argo
serviceAccountName: argo
13 changes: 11 additions & 2 deletions charts/kubeflow-pipelines/values.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
# Global registry override options for container images:
# - Kubeflow: defaults to ghcr.io/kubeflow
# - ML-Pipeline: defaults to gcr.io/ml-pipeline
# - TensorFlow Extended (TFX): defaults to gcr.io/tfx-oss-public
global:
kubeflowRegistry:
mlPipelineRegistry:
tfxOssPublicRegistry:

objectStorage:
endpoint: ""
region: ""
Expand All @@ -21,7 +30,7 @@ metadataWriter:
mlPipeline:
resources: {}

mlPipelinePersistenceagent:
mlPipelinePersistenceagent:
resources: {}

mlPipelineScheduledworkflow:
Expand All @@ -46,4 +55,4 @@ mysql:
- ReadWriteOnce

workflowController:
resources: {}
resources: {}
11 changes: 9 additions & 2 deletions values/kubeflow-pipelines/kubeflow-pipelines.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
{{- $obj := $v.obj.provider }}
{{- $lb := index $obj.linode.buckets "kubeflow-pipelines" }}

{{- if $v.otomi.linodeLkeImageRepository }}
global:
kubeflowRegistry: "{{ $v.otomi.linodeLkeImageRepository }}/ghcr/kubeflow"
mlPipelineRegistry: "{{ $v.otomi.linodeLkeImageRepository }}/gcr/ml-pipeline"
tfxOssPublicRegistry: "{{ $v.otomi.linodeLkeImageRepository }}/gcr/tfx-oss-public"
{{- end }}

objectStorage:
{{- if eq $obj.type "minioLocal" }}
endpoint: minio.minio.svc.cluster.local:9000
Expand All @@ -27,7 +34,7 @@ metadataEnvoy:
metadataGrpc:
resources: {{- $kfp.resources.metadataGrpc | toYaml | nindent 4 }}

metadataWriter:
metadataWriter:
resources: {{- $kfp.resources.metadataWriter | toYaml | nindent 4 }}

mlPipeline:
Expand Down Expand Up @@ -57,4 +64,4 @@ mysql:
- ReadWriteOnce

workflowController:
resources: {{- $kfp.resources.workflowController | toYaml | nindent 4 }}
resources: {{- $kfp.resources.workflowController | toYaml | nindent 4 }}