Skip to content

Multi transitions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 104 commits into
base: master
Choose a base branch
from
Open

Multi transitions #1

wants to merge 104 commits into from

Conversation

shiroganee
Copy link

Please provide enough information so that others can review your pull request:

Explain the motivation for making this change. What existing problem does the pull request solve?

Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise split it.

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Make sure you test on both platforms if your change affects both platforms.

The code must pass tests and shouldn't add more Flow errors.

Code formatting

Look around. Match the style of the rest of the codebase.

* master: (55 commits)
  More gestures cleanup (react-navigation#353)
  CardStack: Don't overwrite custom transitionConfig with default (react-navigation#99)
  Update react-native-tab-view (react-navigation#366)
  Make future proof (and also fix it for the current beta) (react-navigation#322)
  Remove 'appBar' child component to fully support header styling (react-navigation#341)
  1.0.0-beta.5
  1.0.0-beta.4
  Update yarn.lock to include react 15.4.2
  Exported withNavigation to web (react-navigation#330)
  Overwrite 1x.ios as well
  Fix gesture recognition in card stack (react-navigation#324)
  Fix flow (react-navigation#305)
  adds button to photo screen (react-navigation#301)
  Add `showIcon` to `tabBarOptions` so that icons can be hidden on iOS (react-navigation#291)
  [FLOW] Fix missing "type" in flow import.
  Fix style prop for header
  Remove uncompleted sentence in Contributors guide. (react-navigation#280)
  Add missing characters to navigators api doc (react-navigation#264)
  Set numberOfLines to 1 for HeaderTitle (react-navigation#260)
  Add code sample for google analytics integration (react-navigation#107)
  ...
lintonye added 29 commits March 4, 2017 13:20
* master: (21 commits)
  move from react-native-drawer-layout to react-native-drawer-layout-polyfill
  Make TabNavigator code example formatting consistent (react-navigation#462)
  screen props warning removed
  Fix typo (react-navigation#554)
  Change <Header /> layout back to `absolute` (react-navigation#562)
  Update Screen-Tracking.md (react-navigation#549)
  Update Screen-Tracking.md (react-navigation#545)
  Accept tabBar label to be a function (react-navigation#524)
  add import to clarify source of helper (react-navigation#517)
  [Docs] Link every heading automatically (react-navigation#459)
  v1.0.0-beta.6
  Fix TabBarBottom item layout (react-navigation#499)
  fix typo (react-navigation#496)
  Add router prop for the DrawerNavigator content component (react-navigation#487)
  Fix glitches in Header when calling `replace`  (react-navigation#418)
  Add onNavigationStateChange (react-navigation#453)
  Add React.Element support for TabBar/Drawer and fix docs (react-navigation#451)
  fix (react-navigation#454)
  Fix redux documentation (react-navigation#450)
  Remove screen tracking without redux (react-navigation#449)
  ...
* master:
  Docs: Update md links from coodoo's fork to react-community (react-navigation#750)
  Navigation Actions Doc (react-navigation#338)
  Update documentation regarding `DrawerNavigator` customisation (react-navigation#646)
  Fix flow in Navigation Playground (react-navigation#735)
  Adds documentation about forking and syncing repo (react-navigation#765)
  fix(docs): Fix incorrect style in TabNavigator sample (react-navigation#734)
  correction of a few documentation typo (react-navigation#563)
  Fix typo in docs for getComponentForRouteName (react-navigation#714)
  Drawer sidebar description (react-navigation#617)
  Remove 2nd return statement (react-navigation#661)
  Resolve gesture issues in CardStack
  Update dependencies
  Bump version number (react-navigation#650)
  Update react-native-tab-view. Fixes react-navigation#476 (react-navigation#641)
  Remove top margin from drawer view (react-navigation#642)
  Pass `transitionProps`, `prevTransitionProps` and `isModal` to custom `TransitionConfig` (react-navigation#565)
  Fix issue where initialRouteParams were not set (react-navigation#150)
@shiroganee
Copy link
Author

Ups sorry for that lintoneye xD didn't want to actually make PR out of your own changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants