Skip to content

Conversation

borfast
Copy link
Contributor

@borfast borfast commented Aug 12, 2025

In the context of IN-524, we want a couple of API endpoints to return whether a repository is archived, both when fetching the project list, and when searching.

This PR modifies the necessary types to include this data, as well as the code that handles the TinyBird response from the project_list pipe.

It also adds a more explicit type for one of the properties of ProjectTinybird.

Tickets in Jira:

@borfast borfast requested a review from emlimlf August 12, 2025 23:43
@borfast borfast self-assigned this Aug 12, 2025
@borfast borfast added the feature New feature or request label Aug 12, 2025
@borfast borfast marked this pull request as ready for review August 14, 2025 08:53
@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 08:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for tracking archived and excluded repositories in the project data structure. The changes modify the API to return repository archive status for both project list and search endpoints, supporting the requirement to expose this information to the frontend.

  • Adds archived and excluded boolean fields to search repository results
  • Extends project types to include arrays of archived and excluded repository identifiers
  • Updates API handlers to populate the new fields with data from TinyBird responses

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
frontend/types/search.ts Adds archived and excluded boolean fields to SearchRepository interface
frontend/types/project.ts Adds archived/excluded repository arrays to Project and ProjectTinybird interfaces, improves type safety for repoData
frontend/server/api/search.ts Updates search API to return archived and excluded status for repositories
frontend/server/api/project/[slug]/index.ts Populates archived and excluded repository arrays in project detail response

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@borfast borfast force-pushed the feature/in-524-add-archived-repos-to-projects branch from a4ec96c to cfccd54 Compare August 14, 2025 11:35
@borfast borfast force-pushed the feature/in-524-add-archived-repos-to-projects branch from cfccd54 to 92d229c Compare August 26, 2025 22:19
Copy link
Collaborator

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borfast looks good to me according to what we have on the design.
Just wanted to double check. On the project endpoint, when we return a string array of archivedRepositories and excludedRepositories, will it be a list of repo urls?

@borfast
Copy link
Contributor Author

borfast commented Aug 30, 2025

On the project endpoint, when we return a string array of archivedRepositories and excludedRepositories, will it be a list of repo urls?

@joanagmaia, yes, it will be a list of repository URLs ✔️

@borfast borfast force-pushed the feature/in-524-add-archived-repos-to-projects branch from 92d229c to 9720074 Compare September 1, 2025 17:02
@borfast borfast closed this Sep 1, 2025
@borfast borfast force-pushed the feature/in-524-add-archived-repos-to-projects branch from 9720074 to 04371a1 Compare September 1, 2025 17:03
@borfast
Copy link
Contributor Author

borfast commented Sep 1, 2025

This was automatically closed by mistake 🤦‍♂️
I'll reopen a new PR from the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants