-
Notifications
You must be signed in to change notification settings - Fork 7
feat: change the data structure for project data to include archived repositories #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for tracking archived and excluded repositories in the project data structure. The changes modify the API to return repository archive status for both project list and search endpoints, supporting the requirement to expose this information to the frontend.
- Adds
archived
andexcluded
boolean fields to search repository results - Extends project types to include arrays of archived and excluded repository identifiers
- Updates API handlers to populate the new fields with data from TinyBird responses
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
frontend/types/search.ts | Adds archived and excluded boolean fields to SearchRepository interface |
frontend/types/project.ts | Adds archived/excluded repository arrays to Project and ProjectTinybird interfaces, improves type safety for repoData |
frontend/server/api/search.ts | Updates search API to return archived and excluded status for repositories |
frontend/server/api/project/[slug]/index.ts | Populates archived and excluded repository arrays in project detail response |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a4ec96c
to
cfccd54
Compare
cfccd54
to
92d229c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@borfast looks good to me according to what we have on the design.
Just wanted to double check. On the project endpoint, when we return a string array of archivedRepositories and excludedRepositories, will it be a list of repo urls?
@joanagmaia, yes, it will be a list of repository URLs ✔️ |
92d229c
to
9720074
Compare
9720074
to
04371a1
Compare
This was automatically closed by mistake 🤦♂️ |
In the context of IN-524, we want a couple of API endpoints to return whether a repository is archived, both when fetching the project list, and when searching.
This PR modifies the necessary types to include this data, as well as the code that handles the TinyBird response from the project_list pipe.
It also adds a more explicit type for one of the properties of
ProjectTinybird
.Tickets in Jira: