-
Notifications
You must be signed in to change notification settings - Fork 123
Remove dependencies to external binarys #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@clefebvre what needs to happen, that this can be merged? I am interested in improving timeshift further, but i dont want to pull that many branches along, without knowing, if they ever get merged. |
This work seems valuable, as do some of the other pending pull-requests within this repository. |
Hi, this commit makes timeshift fail to build with this error:
|
What distro? Are there any other warnings in the build leading up to that? (like during the configure phase) It builds ok locally and in our github automation. |
Thank you for your response. I'm on Arch Linux and trying to build this exact commit yields these logs: Configure phase:
Build phase:
|
I'm really not sure - the configuration looks ok, and it compiles other files using Posix namespace leading up to that error. Does the build complete successfully if you temporarily comment that line? Are you using the 'official' build recipe for Arch or your own? |
I'm compiling it directly from github as per development.md. As far as I know, the official build recipe doesn't build from last git commit but rather a release version, which doesn't come to Arch yet, but nevertheless that one also builds fine. |
The dependencies are probably unchanged from the current Arch version - I'd check their dependency list, which may have something our instructions are missing. |
For some reason Posix.readlink() is not available in some environments. ref: #333 (comment) Fixes #429.
I can confirm the error (and fix is working) on Manjaro. Software Information:
|
I can confirm that I can build it again manually in Arch Linux! Thanks :D |
I have started to remove some dependencies to external binarys, as easy alternatives are available.
This makes those actions of timeshift faster and more efficient, as fewer syscalls are required to archive the same result. It also allows timeshift to have more detailed knowledge about the errors that might happen.
in future pull requests i would like to remove more dependencies to simple programms, such as cp, touch, mount, umount, chown, chmod ...