[Next] simplify AsyncTask
code and use RsyncTask
to estimate Snapshot size
#428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues what i started with #427.
This does not mean #427 is obsolete. #427 still helps to combat a race condition.
What did i do here?
AsyncTask
AsyncTask.is_terminated
AsyncTask.log_file
read_status
from TasksAsyncTask
finish_task
toAsyncTask
(its code was already contained insidefinish
)prepare
virtual and move base implementation toAsyncTask
execute
toAsyncTask
RsyncTask.regex_list
an array (this avoids stupid typo bugs and i guess its a little not noticeable performance improvement)RsyncTask
to estimate snapshot size (this is the thing i mentioned in only kill a task if its pid is set #427) This way it can be canceled and run in the background