Convert static styles/properties getter to class fields #495
Conversation
aomarks
commented
Sep 10, 2021
aomarks
commented
- Convert static styles getters to static class fields
- Convert static properties getters to static class fields
- Replace invalid curly quotes with straight quotes in code samples
- Update localization docs for JS
|
A live preview of this PR will be available at the URL(s) below. https://pr495-b3b17ea---lit-dev-5ftespv5na-uc.a.run.app/ |
| ]; | ||
| } | ||
| static styles = [ | ||
| super.styles || [], |
There was a problem hiding this comment.
| super.styles || [], | |
| super.styles ?? [], |
|
Have we decided that this style is OK now? When we released the first RC, the call was still to use the static getters because static class fields were problematic... somewhere. Yeah, I wish I remembered, too. Maybe @justinfagnani does. |
Static class fields were added in Chrome 72 (January 2019), Firefox 75 (April 2020), Safari 14.1 (May 2021). So I assume the decision was made because Safari didn't have them yet when the lit.dev docs were first written, but now it does. |
|
Yep--that was it. Thanks, Al! |
This actually broke in #495 where I forgot to update these ranges.
This actually broke in #495 where I forgot to update these ranges.
This actually broke in #495 where I forgot to update these ranges.
This actually broke in #495 where I forgot to update these ranges.
- Replace home-page-specific language toggle with the new global one. - Replace the separate JavaScript vs TypeScript "Hello World" Playground examples with a unified one. I'm keeping the JS output hand-rolled for this example for now, because the `static properties` block isn't in the perfect position, and this is a very prominent example. Will fix in lit/lit#2159 as followup. - Fix home page highlight positions when in JS mode. This actually broke in #495 where I forgot to update the ranges for the yellow-highlight effect. - Added a check for generated samples that have lost or re-ordered playground fold/hide comments. This should help detect weird cases that might need hand-rolling going forward. - Hand-roll two examples that are losing fold comments, and move one comment to be trailing so that it's not lost, that I found via the above check. Filed lit/lit#2158 to hopefully address in the transformers in the future. - Remove some unnecessary TypeScript vs JavaScript language, and add a few more switchable samples. - Remove `jsSamples` mod feature flag to launch JS docs. Fixes #332 Fixes #490
