Enhac(exp): Adds support for non-default vpc for the az down experiment #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != None: | ||
| return err | ||
| else: | ||
| err = statusAws.attachSubnet(experimentsDetails, subnet) |
There was a problem hiding this comment.
can we support for multiple subnets.
uditgaurav
force-pushed
the
az-down-non-default-vpc
branch
3 times, most recently
from
06f7e79 to
6aa91ab
Compare
uditgaurav
force-pushed
the
az-down-non-default-vpc
branch
from
6aa91ab to
85ef6e1
Compare
Signed-off-by: uditgaurav <[email protected]>
uditgaurav
force-pushed
the
az-down-non-default-vpc
branch
from
85ef6e1 to
6d6f6cb
Compare
Jonsy13
approved these changes
Jul 15, 2022
Adarshkumar14
approved these changes
Jul 15, 2022
avaakash
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: uditgaurav [email protected]
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag