feat: add metrics #190
Merged
feat: add metrics #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37ea09e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nbsp
force-pushed
the
nbsp/add/metrics
branch
from
789dca3 to
940636f
Compare
theomonnom
reviewed
Dec 2, 2024
Comment on lines
+62
to
63
| protected output = new AsyncIterableQueue<ChatChunk>(); | ||
| protected queue = new AsyncIterableQueue<ChatChunk>(); |
There was a problem hiding this comment.
The two queues are kind of confusing. If I'm a user implementing a plugin, I would not be sure which one to use
There was a problem hiding this comment.
i'm currently looking into replacing AsyncIterableQueue with web streams across the whole framework, which have a tee function
theomonnom
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.