Allow set connect retry to connect function #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen2986
force-pushed
the
connect-retry
branch
from
cf49991 to
efed63c
Compare
davidliu
reviewed
Jan 7, 2024
| val protocolVersion = maxOf(options.protocolVersion, ProtocolVersion.v7) | ||
| val connectOptions = options.copy(protocolVersion = protocolVersion) | ||
|
|
||
| room.connect(url, token, connectOptions) |
There was a problem hiding this comment.
This should be added to the room.connect function itself rather than this one. LiveKit.connect is deprecated and will be removed in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios, users may encounter connectivity issues that prevent them from joining a room. Implementing a simple retry mechanism can effectively resolve these issues.