Fix: Start ByteStreamWriter chunk index at 0 #430 #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
ByteStreamWriter
where the first data chunk was incorrectly sent with chunk_index = 1 instead of the expected 0.Problem:
As described in Issue #430 , the
_next_chunk_index
was incremented before being used in the write method, causing incompatibility with clients (like the Unity SDK's ByteStreamReader) that expect stream chunk indices to start at 0.This differs from the behavior of
TextStreamWriter
, which correctly starts at index 0.Changes:
The ByteStreamWriter.write method has been modified to:
Use the current value of
_next_chunk_index
(which starts at 0 inBaseStreamWriter
) for the chunk_index.Increment
_next_chunk_index
after the chunk message has been sent via_send_chunk
.This aligns the behavior with
TextStreamWriter
and ensures correct 0-based indexing for byte streams, resolving client-side errors related to chunk index expectation.