Skip to content

update base ubuntu image in Dockerfile #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ad-astra-video
Copy link
Collaborator

@ad-astra-video ad-astra-video commented May 30, 2025

What does this pull request do? Explain your changes. (required)

Update go-livepeer to use ubuntu 22.04 in base image. Ubuntu 22.04 security maintenance expires in April 2027.

I tested on my test gateway and locally noting no issues but more testing should be done.

Should we bump to cuda 12.8 to add Blackwell support? There is no need transcoding related for Blackwell support yet.

Note minimum driver requirements:
image

Specific updates (required)

  • updated Dockerfile and Dockerfile.base
  • added regular cuda path to CPATH, LIBRARY_PATH and CGO_LDFLAGS to enable building without the livepeerci version of the base image

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the docker Pull requests that update Docker code label May 30, 2025
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.76671%. Comparing base (55dcd83) to head (5cad9df).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3600         +/-   ##
===================================================
+ Coverage   30.76453%   30.76671%   +0.00218%     
===================================================
  Files            153         153                 
  Lines          45832       45832                 
===================================================
+ Hits           14100       14101          +1     
+ Misses         30911       30910          -1     
  Partials         821         821                 

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55dcd83...5cad9df. Read the comment docs.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszko
Copy link
Contributor

leszko commented May 30, 2025

Fine with me, but I see the CI build is failing.

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but I see the CI build is failing.

@ad-astra-video
Copy link
Collaborator Author

How is the livepeerci/cuda:12.6.3-cudnn-devel-ubuntu22.04 created? I updated the Dockerfile.cuda-base but it does not seem to be creating it?

@leszko
Copy link
Contributor

leszko commented Jun 2, 2025

How is the livepeerci/cuda:12.6.3-cudnn-devel-ubuntu22.04 created? I updated the Dockerfile.cuda-base but it does not seem to be creating it?

This is the instruction:

# livepeerci/cuda:12.0.0-cudnn8-devel-ubuntu20.04

Do you have access to push into Docker Hub livepeerci? If not, I can build and push the new image. Let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants