chore: Code refactoring and removing dead code #3664
Draft
+104
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omaryashraf5
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf and
slekkala1
as code owners
meta-cla
bot
added
the
CLA Signed
omaryashraf5
changed the title
added 3 commits
October 6, 2025 11:39
- Restored CompletionResponse and CompletionResponseStreamChunk classes in inference.py - Fixed SamplingParams import in test_resolver.py - Fixed openai_compat.py imports - Added missing pytest configuration files - Fixed registry error messages - All fixes needed to make CI tests pass
This fixes the CI failure: NameError: name 'SamplingParams' is not defined The test_resolver.py file needed to import SamplingParams from llama_stack.apis.inference to resolve the CI test collection error.
omaryashraf5
force-pushed
the
dead_code_removal
branch
from
cd5bef1 to
3b1add3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes dead code in some of the inference adapters.
Test Plan
ci