feat: reuse previous mcp tool listings where possible #3710
+1,793
−946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grs
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf,
slekkala1 and
franciscojavierarceo
as code owners
meta-cla
bot
added
the
CLA Signed
Signed-off-by: Gordon Sim <[email protected]>
ehhuang
reviewed
Oct 6, 2025
llama_stack/providers/inline/agents/meta_reference/responses/streaming.py
Outdated
Show resolved
Hide resolved
tests/unit/providers/agents/meta_reference/test_openai_responses.py
Outdated
Show resolved
Hide resolved
ehhuang
reviewed
Oct 7, 2025
| assert isinstance(inference_messages[i], OpenAIDeveloperMessageParam) | ||
|
|
||
|
|
||
| async def test_prepend_previous_response_basic(openai_responses_impl, mock_responses_store): |
ehhuang
approved these changes
Oct 7, 2025
Comment on lines
+118
to
+124
| # Handle all mcp tool lists from previous response that are still valid: | ||
| for tool in self.ctx.tool_context.previous_tool_listings: | ||
| async for evt in self._reuse_mcp_list_tools(tool, output_messages): | ||
| yield evt | ||
| # Process all remaining tools (including MCP tools) and emit streaming events | ||
| if self.ctx.tool_context.tools_to_process: | ||
| async for stream_event in self._process_tools(self.ctx.tool_context.tools_to_process, output_messages): |
There was a problem hiding this comment.
nit: can we still have all this logic in _process_tools? and maybe rename the existing function to _process_new_tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR checks whether, if a previous response is linked, there are mcp_list_tools objects that can be reused instead of listing the tools explicitly every time.
Closes #3106
Test Plan
Tested manually.
Added unit tests to cover new behaviour.