chore: require valid logging category #3712
Open
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
# What does this PR do? ## Test Plan
ehhuang
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf,
slekkala1 and
franciscojavierarceo
as code owners
ashwinb
approved these changes
Oct 7, 2025
leseb
requested changes
Oct 7, 2025
| if root_category in _category_levels: | ||
| log_level = _category_levels[root_category] | ||
| else: | ||
| assert category == UNCATEGORIZED, ( |
There was a problem hiding this comment.
don't use assert and print available categories?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
grep'd and audited all usage of 'get_logger' with help of Claude.
Test Plan
CI