Skip to content

chore!: remove --image-type and --image-name from llama stack run #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: pr3711
Choose a base branch
from
Draft

chore!: remove --image-type and --image-name from llama stack run #3714

wants to merge 1 commit into from

Conversation

ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Oct 6, 2025 •
edited
Loading

What does this PR do?

Simplifies the CLI. I don't think these options make sense anymore: only venv is supported as image-type, and users can simply activate the env before running llama stack as they do any other project.

Test Plan

Stack created with Sapling. Best reviewed with ReviewStack.

@ehhuang ehhuang changed the base branch from main to pr3711 October 6, 2025 23:02
@ehhuang ehhuang mentioned this pull request Oct 6, 2025
Open
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 6, 2025
@ehhuang ehhuang marked this pull request as draft October 6, 2025 23:04
ashwinb
ashwinb reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with me. want to see what @leseb, @cdoern and others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@leseb leseb Awaiting requested review from leseb leseb is a code owner

@bbrowning bbrowning Awaiting requested review from bbrowning bbrowning is a code owner

@reluctantfuturist reluctantfuturist Awaiting requested review from reluctantfuturist reluctantfuturist is a code owner

@mattf mattf Awaiting requested review from mattf mattf is a code owner

@slekkala1 slekkala1 Awaiting requested review from slekkala1 slekkala1 is a code owner

@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo franciscojavierarceo is a code owner

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehhuang @ashwinb