StructAttr -> AttrDef in CIROps.td

[inclyc]

Hi @bcardosolopes

I've noticed there are many warnings said: note: StructAttr is being removed on June 20 while generating defs in CIROps.td

Should we consider using AttrDef as mentioned in D127370 ?

I'm not familiar with Clang IR code base currently but I'd like to contribute if so.

Link: https://discourse.llvm.org/t/psa-structattr-is-deprecated-and-is-being-removed/63068

[lanza]

Yes, this is something we have to do. I just locally reverted the StructAttr removing patches since the fix is somewhat non-trivial. I plan on getting to that at some point in the next few weeks.

[bcardosolopes]

Thanks for documenting the issue @inclyc, on top of what @lanza said, we also welcome patches in case this is something you'd like to fix :)

Cheers!

[inclyc]

Thanks for documenting the issue @inclyc, on top of what @lanza said, we also welcome patches in case this is something you'd like to fix :)

Cheers!

Hi @bcardosolopes , seems @lanza has made patches locally and to avoid any duplicated work I'm looking for some other issue.

[inclyc]

Uhh, it was accidently closed by my mobile device (

[bcardosolopes]

@inclyc the only thing he did was to revert the commit that "changed the deprecation into the actual remove of StructAttr", and that revert is already in the repo (no local unpushed work), once code is changed not to use StructAtt we will undo the revert. So it's still pretty much open if you feel like taking this :)