[CIR][Lowering][x86_64] Initial VAArg support #1086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
ChuanqiXu9
force-pushed
the
VAArgInX86
branch
from
94a5b92 to
56413e1
Compare
ChuanqiXu9
force-pushed
the
VAArgInX86
branch
from
56413e1 to
d2bccf7
Compare
bcardosolopes
requested changes
Nov 8, 2024
| @@ -1,7 +1,5 @@ | |||
| // RUN: %clang_cc1 -triple aarch64-none-linux-android21 -fclangir -emit-cir %s -o %t.cir | |||
| // RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s | |||
| // RUN: %clang_cc1 -triple aarch64-none-linux-android21 -fclangir -emit-llvm -fno-clangir-call-conv-lowering %s -o %t.ll | |||
| // RUN: FileCheck --check-prefix=LLVM --input-file=%t.ll %s | |||
There was a problem hiding this comment.
We don't want to loose the LLVM testing here, even though it might be wrong in the ABI sense for AArch64, it's still testing some important parts. Can you elaborate on why are you remove this? Should this be moved elsewhere instead?
There was a problem hiding this comment.
Oh, this is a surprise to me too. My bad. I should check the PR. BTW, I like to close this one and create a new one to make the stacked PR for #1087
bcardosolopes
changed the title
bcardosolopes
changed the title
|
Close to create stacked PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements transformations for VAArg in X86_64 ABI in shape.
In shapemeans it can't work properly due to the dependent X86_64 ABI is not robust. e.g., when we want to use VAArg withlong double, we need #1087.This patch literally implement https://github.com/llvm/llvm-project/blob/d233fedfb0de882353c348cd1ac57dab619efa6d/clang/lib/CodeGen/Targets/X86.cpp#L3015-L3240 in CIR.
There some differences due to the traditional pipeline are converting AST to LLVM and we're transforming CIR to CIR. And also to get the ABI Info, I moved
X86_64ABIInfoto the header.