Skip to content

[CIR][ABI][AArch64][Lowering] support for calling struct types in range (64, 128) #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 25, 2024
Merged

[CIR][ABI][AArch64][Lowering] support for calling struct types in range (64, 128) #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4dbcde3
initial commit
bruteforceboy Nov 19, 2024
4de115b
update tests
bruteforceboy Nov 19, 2024
92bf363
cleanup
bruteforceboy Nov 19, 2024
1e4f5d9
add NYI
bruteforceboy Nov 19, 2024
28a5f7e
Update LowerFunction.cpp
bruteforceboy Nov 19, 2024
5d47b2a
Update LowerFunction.cpp
bruteforceboy Nov 19, 2024
b270c72
[CIR][ABI][AArch64][Lowering] Support structures with padding (#1118)
bruteforceboy Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clang/lib/CIR/Dialect/Transforms/TargetLowering/LowerFunction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,13 @@ mlir::Value createCoercedValue(mlir::Value Src, mlir::Type Ty,
return CGF.buildAggregateBitcast(Src, Ty);
}

if (auto alloca = findAlloca(Src.getDefiningOp())) {
auto tmpAlloca = createTmpAlloca(CGF, alloca.getLoc(), Ty);
createMemCpy(CGF, tmpAlloca, alloca, SrcSize.getFixedValue());
return CGF.getRewriter().create<LoadOp>(alloca.getLoc(),
tmpAlloca.getResult());
}

cir_cconv_unreachable("NYI");
}

Expand Down
25 changes: 25 additions & 0 deletions clang/test/CIR/CallConvLowering/AArch64/aarch64-cc-structs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,31 @@ GT_128 call_and_get_gt_128() {
// LLVM: call void @llvm.memcpy.p0.p0.i64(ptr %[[#V1]], ptr %[[#V2]], i64 12, i1 false)
void passS(S s) {}

// CHECK: @callS()
// CHECK: %[[#V0:]] = cir.alloca !ty_S, !cir.ptr<!ty_S>, ["s"] {alignment = 4 : i64}
// CHECK: %[[#V1:]] = cir.alloca !cir.array<!u64i x 2>, !cir.ptr<!cir.array<!u64i x 2>>, ["tmp"] {alignment = 8 : i64}
// CHECK: %[[#V2:]] = cir.load %[[#V0]] : !cir.ptr<!ty_S>, !ty_S
// CHECK: %[[#V3:]] = cir.cast(bitcast, %[[#V0]] : !cir.ptr<!ty_S>), !cir.ptr<!void>
// CHECK: %[[#V4:]] = cir.cast(bitcast, %[[#V1]] : !cir.ptr<!cir.array<!u64i x 2>>), !cir.ptr<!void>
// CHECK: %[[#V5:]] = cir.const #cir.int<12> : !u64i
// CHECK: cir.libc.memcpy %[[#V5]] bytes from %[[#V3]] to %[[#V4]] : !u64i, !cir.ptr<!void> -> !cir.ptr<!void>
// CHECK: %[[#V6:]] = cir.load %[[#V1]] : !cir.ptr<!cir.array<!u64i x 2>>, !cir.array<!u64i x 2>
// CHECK: cir.call @passS(%[[#V6]]) : (!cir.array<!u64i x 2>) -> ()
// CHECK: cir.return

// LLVM: @callS()
// LLVM: %[[#V1:]] = alloca %struct.S, i64 1, align 4
// LLVM: %[[#V2:]] = alloca [2 x i64], i64 1, align 8
// LLVM: %[[#V3:]] = load %struct.S, ptr %[[#V1]], align 4
// LLVM: call void @llvm.memcpy.p0.p0.i64(ptr %[[#V2]], ptr %[[#V1]], i64 12, i1 false)
// LLVM: %[[#V4:]] = load [2 x i64], ptr %[[#V2]], align 8
// LLVM: call void @passS([2 x i64] %[[#V4]])
// LLVM: ret void
void callS() {
S s;
passS(s);
}

typedef struct {
uint8_t a;
uint16_t b;
Expand Down