Skip to content

[CIR] Fix build due to deprecated interfaces #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

[CIR] Fix build due to deprecated interfaces #1299

merged 1 commit into from
Jan 28, 2025

Conversation

darkbuck
Copy link
Contributor

  • After abba01a, 'is' and 'get' interfaces are deprecated even though not removed yet. However, it causes warnings and triggers build failures if that warnings are treated as errors.

@darkbuck
[CIR] Fix build due to deprecated interfaces
1213b1e 
- After abba01a, 'is' and 'get'
  interfaces are deprecated even though not removed yet. However, it
  causes warnings and triggers build failures if that warnings are
  treated as errors.
@Lancern Lancern mentioned this pull request Jan 28, 2025
Closed
@darkbuck darkbuck closed this Jan 28, 2025
@darkbuck darkbuck reopened this Jan 28, 2025
@andykaylor andykaylor mentioned this pull request Jan 28, 2025
Merged
bcardosolopes
bcardosolopes approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@bcardosolopes bcardosolopes merged commit cf09dbf into llvm:main Jan 28, 2025
9 of 15 checks passed
AmrDeveloper pushed a commit to AmrDeveloper/clangir that referenced this pull request Jan 29, 2025
@darkbuck @AmrDeveloper
[CIR] Fix build due to deprecated interfaces (llvm#1299)
699c7fb 
- After abba01a, 'is' and 'get'
interfaces are deprecated even though not removed yet. However, it
causes warnings and triggers build failures if that warnings are treated
as errors.
lanza pushed a commit that referenced this pull request Mar 18, 2025
@darkbuck @lanza
[CIR] Fix build due to deprecated interfaces (#1299)
45c9231 
- After abba01a, 'is' and 'get'
interfaces are deprecated even though not removed yet. However, it
causes warnings and triggers build failures if that warnings are treated
as errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkbuck @bcardosolopes