Skip to content

[CIR][CIRGen][NFC] Handle PragmaComment in emitTopLevelDecl #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

[CIR][CIRGen][NFC] Handle PragmaComment in emitTopLevelDecl #1521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa333aa
[CIR][CIRGen] Handle `PragmaComment` in `emitTopLevelDecl`
el-ev Mar 24, 2025
771da49
formatting
el-ev Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions clang/lib/CIR/CodeGen/CIRGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2035,6 +2035,24 @@ void CIRGenModule::emitTopLevelDecl(Decl *decl) {
emitTopLevelDecl(childDecl);
break;
}
case Decl::PragmaComment: {
const auto *PCD = cast<PragmaCommentDecl>(decl);
switch (PCD->getCommentKind()) {
case PCK_Unknown:
llvm_unreachable("unexpected pragma comment kind");
case PCK_Linker:
assert(!MissingFeatures::emitModuleLinkOptions() && "NYI");
break;
case PCK_Lib:
assert(!MissingFeatures::elfDependentLibraries() && "NYI");
break;
case PCK_Compiler:
case PCK_ExeStr:
case PCK_User:
break; // We ignore all of these.
}
break;
}
// No code generation needed.
case Decl::UsingShadow:
case Decl::ClassTemplate:
Expand Down
Loading