[CIR][LowerToLLVM] Support for LinkerOptions lowering #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The codegen parts are currently not testable. #1521 (comment) |
bcardosolopes
requested changes
Mar 28, 2025
| @@ -2041,7 +2041,7 @@ void CIRGenModule::emitTopLevelDecl(Decl *decl) { | |||
| case PCK_Unknown: | |||
| llvm_unreachable("unexpected pragma comment kind"); | |||
| case PCK_Linker: | |||
| assert(!MissingFeatures::emitModuleLinkOptions() && "NYI"); | |||
| appendLinkerOptions(PCD->getArg()); | |||
There was a problem hiding this comment.
If you can't stress this path in the tests because we currently lack support for windows, you shouldn't change anything under lib/CIR/CodeGen as part of this PR. Alternatively you can add the missing windows support in another PR and then re-introduce this.
el-ev
changed the title
bcardosolopes
approved these changes
Apr 1, 2025
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decl::PragmaComment#70.