[CIR][CodeGen] Insert new blocks after ThrowOp expressions

[bruteforceboy]

This PR fixes Issue#1647.

It just takes the implementation from emitRethrow and extends the same logic to emitThrow.

The only nitpick about the fix is same as before - we have this redundant ScopeOp which acts as a placeholder, so there are some redundant yield blocks in some cases. Aside that, I believe this fix is okay for now.

I have added the tests from the issue to confirm everything works as intended.

cc: @mmha, @bcardosolopes.

[mmha]

LGTM. My only request is one more test case:

int ternary_throw(bool condition, int x) {
    return condition ? throw x : x;
}

This tests both the awkward ternary expression case and should make the newly created block take a new argument

[bruteforceboy]

LGTM. My only request is one more test case:

int ternary_throw(bool condition, int x) {
    return condition ? throw x : x;
}

This tests both the awkward ternary expression case and should make the newly created block take a new argument

Sorry for the late reply. I have updated the PR to handle this case. Changes made:

• To get the terminator when building the TernaryOp, we now get the terminator of the last block in the true region instead, since the ThrowOp now splits into multiple blocks.
• Got rid of Lexical scopes [1] [2] in the TernaryOp builder for the AbstractConditionalOperator. I have compared with the original CodeGen and it seems to be the way to go. I have also attached the LLVM output in the tests for verification.

[bcardosolopes]

Awesome! LGTM