Skip to content

[CIR][Codegen] VTT support for virtual class inheritance #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

[CIR][Codegen] VTT support for virtual class inheritance #252

merged 1 commit into from
Sep 13, 2023

Conversation

htyu
Copy link
Contributor

@htyu htyu commented Sep 7, 2023

This patch brings up the basic support for C++ virtual inheritance. VTT (virtual table table) now can be laid out as expected for simple program with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.

@htyu htyu requested a review from bcardosolopes September 7, 2023 18:31
bcardosolopes
bcardosolopes requested changes Sep 7, 2023
View reviewed changes
bcardosolopes
bcardosolopes reviewed Sep 7, 2023
View reviewed changes
@bcardosolopes bcardosolopes mentioned this pull request Sep 13, 2023
Closed
bcardosolopes
bcardosolopes requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to take a last look after you update the PR, but otherwise good to go.

@htyu htyu force-pushed the vbase branch 2 times, most recently from 7337804 to d90fa50 Compare September 13, 2023 22:55
bcardosolopes
bcardosolopes approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one more minor change

@htyu htyu merged commit 470aba9 into llvm:main Sep 13, 2023
lanza pushed a commit that referenced this pull request Oct 27, 2023
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
49f7301 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Dec 20, 2023
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
2e8d154 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Jan 29, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
41b41fa 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Mar 23, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
c6f43d5 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (llvm#252)
bea9906 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (llvm#252)
9a2ac47 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
865d986 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
6b0792f 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (llvm#252)
fc586ad 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
4074112 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (llvm#252)
71a2d6b 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (llvm#252)
015dbb5 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (llvm#252)
c7d6c79 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
7ed8baa 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Mar 18, 2025
@htyu @lanza
[CIR][Codegen] VTT support for virtual class inheritance (#252)
acb8271 
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htyu @bcardosolopes