Skip to content

[CIR][IR] Deprecate cir.yield nosuspend #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2024
Merged

[CIR][IR] Deprecate cir.yield nosuspend #396

merged 2 commits into from
Jan 16, 2024

Conversation

sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Jan 11, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

This changes the cir.await operation to expect a cir.condition as
the terminator for the ready region. This simplifies the cir.await
while also simplifying the cir.yield. If cir.condition holds a
true value, then the cir.await will continue the coroutine, otherwise,
it will suspend its execution.

The cir.condition op was also updated to allow cir.await as its
parent operation.

@sitio-couto
[CIR][IR] Deprecate cir.yield nosuspend
bb86ed9 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

[ghstack-poisoned]
This was referenced Jan 11, 2024
Merged
Merged
Merged
bcardosolopes
bcardosolopes requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, few changes needed.

@sitio-couto
Update on "[CIR][IR] Deprecate cir.yield nosuspend"
b485d76 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

[ghstack-poisoned]
@sitio-couto
Copy link
Collaborator Author

@bcardosolopes applied!

@sitio-couto sitio-couto merged commit b485d76 into gh/sitio-couto/4/base Jan 16, 2024
sitio-couto added a commit that referenced this pull request Jan 16, 2024
@sitio-couto
[CIR][IR] Deprecate cir.yield nosuspend
2f1cf4c 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
@sitio-couto sitio-couto deleted the gh/sitio-couto/4/head branch January 16, 2024 20:53
lanza pushed a commit that referenced this pull request Jan 29, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
c57a568 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
lanza pushed a commit that referenced this pull request Mar 23, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
e8f5078 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
69aec24 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: llvm#396
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
f786bc8 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
a5a5d1a 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
9d08b1c 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: llvm#396
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
2f48e4a 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
5ff763b 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2cfbdeff6f289936d16354cba534e093ea7
Pull Request resolved: llvm/clangir#396
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
050b93c 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: llvm#396
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
600a995 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: llvm#396
lanza pushed a commit that referenced this pull request Nov 5, 2024
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
8e2df2f 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
lanza pushed a commit that referenced this pull request Mar 18, 2025
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
a676747 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2c
Pull Request resolved: #396
lanza pushed a commit to lanza/llvm-project that referenced this pull request Aug 11, 2025
@sitio-couto @lanza
[CIR][IR] Deprecate cir.yield nosuspend
bae6b2c 
This changes the `cir.await` operation to expect a `cir.condition` as
the terminator for the ready region. This simplifies the `cir.await`
while also simplifying the `cir.yield`. If `cir.condition` holds a
true value, then the `cir.await` will continue the coroutine, otherwise,
it will suspend its execution.

The `cir.condition` op was also updated to allow `cir.await` as its
parent operation.

ghstack-source-id: 1ebeb2cfbdeff6f289936d16354cba534e093ea7
Pull Request resolved: llvm/clangir#396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitio-couto @bcardosolopes