Skip to content

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Oct 30, 2023

…314)

replaceValuesPerBlockEntry() only handled simple and coerced load
values, however the load may also be referenced by a select value.

Additionally, I suspect that the previous code might have been incorrect
if a load had an offset, as it always constructed the AvailableValue
from scratch.

Fixes llvm/llvm-project#69301.

(cherry picked from commit 7f1733a252cbbad74445bd54dc95aeec52bb3199)
@tru
Copy link
Contributor

tru commented Oct 31, 2023

@nikic since this is the same or similar as #742 I guess it's safe to merge?

@nikic
Copy link
Contributor

nikic commented Oct 31, 2023

@tru Yeah, this is the same change just with updated check lines. Can you please also close the other PR, as I can't do it myself?

@tru tru merged commit c2eab59 into release/17.x Oct 31, 2023
@tru tru deleted the nikic-gvn-backport branch October 31, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GVN] Use after free during load PRE
3 participants