Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 3acccf0

Browse files
committedMar 30, 2025·
[MC] Don't print () around $ names
This MIPS behavior from edb9d84 (2010) is obsoleted and misleading. This caused confusion in https://reviews.llvm.org/D123702 ([NVPTX] Disable parens for identifiers starting with '$') Note: $tmp was rejected by AsmParser before https://reviews.llvm.org/D75111 (2020)
1 parent e5fcbfa commit 3acccf0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+227
-245
lines changed
 

‎llvm/include/llvm/MC/MCAsmInfo.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -650,9 +650,6 @@ class MCAsmInfo {
650650
bool doDwarfFDESymbolsUseAbsDiff() const { return DwarfFDESymbolsUseAbsDiff; }
651651
bool useDwarfRegNumForCFI() const { return DwarfRegNumForCFI; }
652652
bool useParensForSymbolVariant() const { return UseParensForSymbolVariant; }
653-
bool useParensForDollarSignNames() const {
654-
return UseParensForDollarSignNames;
Code has comments. Press enter to view.
655-
}
656653
bool supportsExtendedDwarfLocDirective() const {
657654
return SupportsExtendedDwarfLocDirective;
658655
}

‎llvm/include/llvm/MC/MCExpr.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ class MCExpr {
8181
/// \name Utility Methods
8282
/// @{
8383

84-
void print(raw_ostream &OS, const MCAsmInfo *MAI,
85-
bool InParens = false) const;
84+
void print(raw_ostream &OS, const MCAsmInfo *MAI) const;
8685
void dump() const;
8786

8887
/// Returns whether the given symbol is used anywhere in the expression or

0 commit comments

Comments
 (0)
Please sign in to comment.