-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[SPIRV] Investigate usage of report_fatal_error
in SPIRVInstructionSelector
#124045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Reverts #123853 The introduction of `reflect-error.ll` surfaced a bug with the use of `report_fatal_error` in `SPIRVInstructionSelector` that was propagated into the pr. This has caused a build-bot breakage, and the work to solve the underlying issue is tracked here: #124045. We can re-apply this commit when the underlying issue is resolved.
…on"" (#124046) Reverts llvm/llvm-project#123853 The introduction of `reflect-error.ll` surfaced a bug with the use of `report_fatal_error` in `SPIRVInstructionSelector` that was propagated into the pr. This has caused a build-bot breakage, and the work to solve the underlying issue is tracked here: llvm/llvm-project#124045. We can re-apply this commit when the underlying issue is resolved.
I will investigate this issue |
@Icohedron working to unblock this, see https://discourse.llvm.org/t/forcing-a-build-on-sanitizer-aarch64-linux-bootstrap-hwasan-to-test-fixes/84402 |
I have successfully reproduced the error on a local machine. The tests for
Case 2 is interesting because, according to buildbot_functions.sh in the llvm-zorg repo, hwasan is the only sanitizer that defines |
Running the
Running it through lldb, the backtrace is as follows:
|
The "pure virtual method called" error does not appear when The |
The |
The |
Ah that makes sense looks like someone fixed a variation of this bug like so 4fed39d |
This bug has been fixed recently. See #125599 (comment) and #125599 (comment) |
Closing this issue since the issue has been fixed (see above comment) and there are actually some other tests that exist which check for |
Throughout
SPIRVInstructionSelector
there are many uses ofreport_fatal_error
to indicate various errors, however, none of these have any associated testing.As part of #123853, this pattern was propagated to report an error and a test was added to ensure the correct error message was received. This caused the
hwasan
build bot to fail.It is assumed that all of the other
report_fatal_error
instances would cause a similar failure if executed on the build-bot, or at the least, the other instance that outputs a diagnostics message printing out the current instruction here.This issue is to track an investigation of which uses of
report_fatal_error
cause the sanitization build-bot to fail, and apply a fix correspondingly.Of the top of my head some potential things to check are:
We don't seem to return
false
after reporting a fatal errorWe have allocated a
diag
message to output through a locally constructed output_stream.AC:
report_fatal_error
messagesThe text was updated successfully, but these errors were encountered: