`warn_second_arg_of_va_start_not_last_named_param` is inaccurate-

[erichkeane]

The diagnostic warn_second_arg_of_va_start_not_last_named_param is inaccurately worded/named. It is actually not a problem of the last NAMED param, it is the last non-variadic parameter. Consider:

See here; #131166 (comment)

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Erich Keane (erichkeane)

The diagnostic `warn_second_arg_of_va_start_not_last_named_param` is inaccurately worded/named. It is actually not a problem of the last NAMED param, it is the last non-variadic parameter. Consider:

See here; #131166 (comment)

[kunxl-gg]

Hey, I am interested to work on this!

[erichkeane]

Hey, I am interested to work on this!

Go for it, enjoy! Let us know if you need any help, else add @AaronBallman and I as reviewers if you get a patch together.