You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After commit 4bdcf5b, the EC symbol in libcall names related to have an extra pair of quotation marks ("), which results in undefined symbol errors during linking.
before this commit EC symble name like this
After commit 4bdcf5b, the EC symbol names in libc related to have an extra pair of quotation marks ("), which results in undefined symbol errors during linking.
befault this commit EC symble name like this
```
llvm-nm test.o | grep memset
U #memset
```
after this commit EC symbol name like this
```
llvm-nm test.o | grep memset
U #"memset"
```
changed the title [-][ARM64EC]Extra pair of quotes added to libc EC symbols causes linker errors[/-][+][ARM64EC]Extra pair of quotes added to libcall names EC symbols causes linker errors[/+]on Jun 12, 2025
changed the title [-][ARM64EC]Extra pair of quotes added to libcall names EC symbols causes linker errors[/-][+][ARM64EC]Extra pair of quotes added to EC symbol libcall name causes linker errors[/+]on Jun 12, 2025
#87542 and whatever commits added the original overrides did not add any tests. This is going to continue breaking without tests. @dpaoliello can you address the original request to add the tests, there really need to be exhaustive tests that cover every ABI function
After commit 4bdcf5b, the EC symbol in libcall names related to have an extra pair of quotation marks ("), which results in undefined symbol errors during linking.
before this commit EC symble name like this
```
llvm-nm test.o | grep memset
U #memset
```
after this commit EC symbol name like this
```
llvm-nm test.o | grep memset
U #"memset"
```
Activity
llvmbot commentedon Jun 12, 2025
@llvm/issue-subscribers-libc
Author: None (SquallATF)
[-][ARM64EC]Extra pair of quotes added to libc EC symbols causes linker errors[/-][+][ARM64EC]Extra pair of quotes added to libcall names EC symbols causes linker errors[/+][-][ARM64EC]Extra pair of quotes added to libcall names EC symbols causes linker errors[/-][+][ARM64EC]Extra pair of quotes added to EC symbol libcall name causes linker errors[/+]arsenm commentedon Jun 12, 2025
#87542 and whatever commits added the original overrides did not add any tests. This is going to continue breaking without tests. @dpaoliello can you address the original request to add the tests, there really need to be exhaustive tests that cover every ABI function
dpaoliello commentedon Jun 12, 2025
FYI @efriedma-quic
I'll put it on my todo list, not sure when I'll have time to get to it though...
llvmbot commentedon Jun 12, 2025
@llvm/issue-subscribers-backend-aarch64
Author: None (SquallATF)
[aarch64] Fix Arm64EC libcall lowering after recent refactoring. (llv…
[aarch64] Fix Arm64EC libcall lowering after recent refactoring. (llv…