Skip to content

[AMDGPU][MC] Many MIMG opcodes do not accept tfe with dmask:0xf #38648

Closed
@dpreobra

Description

@dpreobra
Collaborator
Bugzilla Link 39300
Version trunk
OS All
CC @atamazov,@jayfoad,@arsenm

Extended Description

The reason for this issue is that current implementation does not support 5-register tuples.

Activity

jayfoad

jayfoad commented on Jan 20, 2021

@jayfoad
Contributor

I think this is fixed now. See https://reviews.llvm.org/D94960 which enabled proper disassembly of MIMG instructions with tfe.

dpreobra

dpreobra commented on Jan 22, 2021

@dpreobra
CollaboratorAuthor

Thanks! The patch you mentioned did fix a lot of disassembler failures.

However some tests with 0xf dmask still fail to disassemble.

For example, the following code is disassembled ok for gfx8 and gfx9:

0x00,0x0f,0x44,0xf0,0xfc,0x05,0x02,0x00
image_atomic_cmpswap v[5:8], v252, s[8:15] dmask:0xf

The same code with tfe produces an invalid output for the same GPUs:

0x00,0x0f,0x45,0xf0,0xfc,0x05,0x02,0x00
image_atomic_cmpswap v[5:6], v252, s[8:15] dmask:0xf tfe

Also the following instruction fails to assemble on gfx7-gfx10:

image_atomic_cmpswap v[5:9], v252, s[8:15] dmask:0xf tfe

See also related bugs 48846, 48847

self-assigned this
on Nov 14, 2024
jwanggit86

jwanggit86 commented on Nov 15, 2024

@jwanggit86
Contributor

I think this problem is now fixed with PR 112622.

arsenm

arsenm commented on Nov 15, 2024

@arsenm
Contributor

Seems to work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @jayfoad@arsenm@jwanggit86@dpreobra

      Issue actions

        [AMDGPU][MC] Many MIMG opcodes do not accept tfe with dmask:0xf · Issue #38648 · llvm/llvm-project