Skip to content

Missing returned object destructor call after exception throw #50865

Not planned
@llvmbot

Description

@llvmbot
Bugzilla Link 51523
Version trunk
OS Linux
Reporter LLVM Bugzilla Contributor

Extended Description

14.3.2 Exception handling:Constructors and destructors:2 (https://eel.is/c++draft/except.ctor#2)
says
"If an exception is thrown during the destruction of temporaries or local variables for a return statement ([stmt.return]), the destructor for the returned object (if any) is also invoked"

And it contains example (https://eel.is/c++draft/except.ctor#example-1) with description
"...the local variable y is destroyed, causing stack unwinding, resulting in the destruction of the returned object, ..."

Trying to recreate this example with following code

#include
using namespace std;

struct S{
int i = 123;
S(int i) :i(i) {cout<<"S("<<i<<")"<<endl;}
~S() {cout<<"~S("<<i<<")"<<endl;}
};

struct T {
T() {cout<<"T()"<<endl;}
~T() noexcept(false) {
cout<<"~T()"<<endl;
throw 0;
}
};

S foo() {
try {
T t;
return {3};
} catch (...){}
return {4};
}

int main() {
foo();
}

Output doesn't have S{3}'s (returned object) destruction line:
T()
S(3)
~T()
S(4)
~S(4)

while should be
T()
S(3)
~T()
~S(3) <-----!
S(4)
~S(4)

Link to godbolt:
https://godbolt.org/z/YrasqsvMe

Activity

zygoloid

zygoloid commented on Sep 25, 2023

@zygoloid
Collaborator

Duplicate of #12658

added
duplicateResolved as duplicate
clang:codegenIR generation bugs: mangling, exceptions, etc.
on Sep 26, 2023
llvmbot

llvmbot commented on Sep 26, 2023

@llvmbot
MemberAuthor

@llvm/issue-subscribers-c-1

| | | | --- | --- | | Bugzilla Link | [51523](https://llvm.org/bz51523) | | Version | trunk | | OS | Linux | | Reporter | LLVM Bugzilla Contributor |

Extended Description

14.3.2 Exception handling:Constructors and destructors:2 (https://eel.is/c++draft/except.ctor#2)
says
"If an exception is thrown during the destruction of temporaries or local variables for a return statement ([stmt.return]), the destructor for the returned object (if any) is also invoked"

And it contains example (https://eel.is/c++draft/except.ctor#example-1) with description
"...the local variable y is destroyed, causing stack unwinding, resulting in the destruction of the returned object, ..."

Trying to recreate this example with following code

#include <iostream>
using namespace std;

struct S{
int i = 123;
S(int i) :i(i) {cout<<"S("<<i<<")"<<endl;}
~S() {cout<<"~S("<<i<<")"<<endl;}
};

struct T {
T() {cout<<"T()"<<endl;}
~T() noexcept(false) {
cout<<"~T()"<<endl;
throw 0;
}
};

S foo() {
try {
T t;
return {3};
} catch (...){}
return {4};
}

int main() {
foo();
}

Output doesn't have S{3}'s (returned object) destruction line:
T()
S(3)
~T()
S(4)
~S(4)

while should be
T()
S(3)
~T()
~S(3) <-----!
S(4)
~S(4)

Link to godbolt:
https://godbolt.org/z/YrasqsvMe

llvmbot

llvmbot commented on Sep 26, 2023

@llvmbot
MemberAuthor

@llvm/issue-subscribers-clang-codegen

| | | | --- | --- | | Bugzilla Link | [51523](https://llvm.org/bz51523) | | Version | trunk | | OS | Linux | | Reporter | LLVM Bugzilla Contributor |

Extended Description

14.3.2 Exception handling:Constructors and destructors:2 (https://eel.is/c++draft/except.ctor#2)
says
"If an exception is thrown during the destruction of temporaries or local variables for a return statement ([stmt.return]), the destructor for the returned object (if any) is also invoked"

And it contains example (https://eel.is/c++draft/except.ctor#example-1) with description
"...the local variable y is destroyed, causing stack unwinding, resulting in the destruction of the returned object, ..."

Trying to recreate this example with following code

#include <iostream>
using namespace std;

struct S{
int i = 123;
S(int i) :i(i) {cout<<"S("<<i<<")"<<endl;}
~S() {cout<<"~S("<<i<<")"<<endl;}
};

struct T {
T() {cout<<"T()"<<endl;}
~T() noexcept(false) {
cout<<"~T()"<<endl;
throw 0;
}
};

S foo() {
try {
T t;
return {3};
} catch (...){}
return {4};
}

int main() {
foo();
}

Output doesn't have S{3}'s (returned object) destruction line:
T()
S(3)
~T()
S(4)
~S(4)

while should be
T()
S(3)
~T()
~S(3) <-----!
S(4)
~S(4)

Link to godbolt:
https://godbolt.org/z/YrasqsvMe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugzillaIssues migrated from bugzillac++clang:codegenIR generation bugs: mangling, exceptions, etc.duplicateResolved as duplicate

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @zygoloid@Endilll@llvmbot

        Issue actions

          Missing returned object destructor call after exception throw · Issue #50865 · llvm/llvm-project