llvm-rc: not merging string literals for paths

[jeremyd2019]

Bugzilla Link	51944
Version	12.0
OS	Windows NT
CC	@mstorsjo

Extended Description

I'm not really sure if this is something that only works in windres or if it also works in rc.exe. I came across this rc in virt-viewer

llvm-rc: Error in ICON statement (ID 2):
Is a directory
'['D:/a/temp/msys/msys64/clang64/bin/windres.EXE', '-DICONDIR=\"C://mingw-w64-virt-viewer/src/build-x86_64-w64-mingw32/icons\"', '-DMANIFESTDIR=\"C:/_/mingw-w64-virt-viewer/src/virt-viewer-10.0/src\"', '-i', 'src/virt-viewer.rc', '-o', 'src/virt-viewer-rc.o']' returned non-zero exit status 1.

The RC file in question is https://gitlab.com/virt-viewer/virt-viewer/-/blob/v10.0/src/virt-viewer.rc.in , and the ICON statement is

2 ICON ICONDIR "/virt-viewer.ico"

I assume they meant for that to somehow transform into 2 ICON "C:/_/mingw-w64-virt-viewer/src/build-x86_64-w64-mingw32/icons/virt-viewer.ico". This reminded me of https://reviews.llvm.org/D105621#inline-1004064 but this is in an ICON statement not a user defined resource.

[jeremyd2019]

This project was already using meson configure_file on the rc file so I worked around this by subbing in the full paths there rather than trying to use the preprocessor in this way. https://github.com/msys2/MINGW-packages/blob/360e0b78af982809fb35fa5ed94078f613bea6e5/mingw-w64-virt-viewer/001-rc-generation-fixes.patch

[jeremyd2019]

Another, more common instance seems to exist in an rc file provided by wxWidgets (intended to be included in the rc file for programs using wxWidgets) for their default manifest: https://github.com/wxWidgets/wxWidgets/blob/866cdfe20000178145896497c23ce4598cc88068/include/wx/msw/wx.rc#L122

[ZachBacon]

What seems to be odd is that the issue Jeremy is referencing is what I'm experiencing in an clang msys2 environment in a ci setup. But locally it builds just fine.

Anyways here's the ci logs

https://github.com/ZachBacon/visualboyadvance-m/runs/5057487429?check_suite_focus=true

[hmartinez82]

I was able to reproduce this while building GIMP for Windows using Clang in MSYS2.

Making all in .
make[3]: Entering directory '/d/Dev/Github/gimp/app'
windres --define ORIGINALFILENAME_STR="gimp-2.99.exe" \
        --define INTERNALNAME_STR="gimp-2.99" \
        --define TOP_SRCDIR="`echo .. | sed 's*//*/*'`" \
        -I"`echo ../app | sed 's%/\+%/%'`" \
        -I"`echo ../app | sed 's%/\+%/%'`"\
        -I"`echo .. | sed 's%/\+%/%'`"\
        ../build/windows/gimp.rc gimp-2.99.rc.o
llvm-rc: Error in ICON statement (ID 1):
Is a directory
make[3]: *** [Makefile:1640: gimp-2.99.rc.o] Error 1

The rc file contents:

...
#include "winuser.h"
1	ICON	QUOTE(TOP_SRCDIR) "/build/windows/wilber.ico"
2	ICON	QUOTE(TOP_SRCDIR) "/build/windows/fileicon.ico"
CREATEPROCESS_MANIFEST_RESOURCE_ID RT_MANIFEST QUOTE(TOP_SRCDIR) "/build/windows/gimp.manifest"

[mstorsjo]

I finally took some time to finish my half-done attempt at fixing this, and posted it for review at #68685.