Skip to content

Cherry-pick AArch64/GlobalISel fp copy fix #53162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikic opened this issue Jan 12, 2022 · 4 comments
Closed

Cherry-pick AArch64/GlobalISel fp copy fix #53162

nikic opened this issue Jan 12, 2022 · 4 comments

Comments

@nikic
Copy link
Contributor

nikic commented Jan 12, 2022

04fb9b7 fixes a miscompile in AArch64 debug builds using GlobalISel, where previously nonsensical mrs NZCV instructions were inserted (originally reported at rust-lang/rust#92786).

The patch does not apply cleanly to 13.x, I have rebased it here: nikic@1715dad Notably the test output in the truncating_f8 test is slightly different, there are three COPYs on 13.x rather than two. I'm not sure whether that is okay or indicative of a problem (maybe @aemerson can confirm).

If it's too late for the 13.0.1 release, we'll carry this patch on the rustc side.

@llvmbot
Copy link
Member

llvmbot commented Jan 14, 2022

@llvm/issue-subscribers-backend-AArch64

@tstellar
Copy link
Collaborator

@TNorthover What do you think about this?

@TNorthover
Copy link
Contributor

Yep, I think this one is good too.

@nikic
Copy link
Contributor Author

nikic commented Jan 25, 2022

Removing this as a backport candidate -- this failed rustc aarch64 testing with:

B0 = COPY H0
unimplemented reg-to-reg copy

So probably this patch has some other dependency on the main branch, but I haven't figure out what it is yet.

@nikic nikic closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants