Skip to content

Cherry-pick AArch64/GlobalISel fp copy fix #53162

Closed
@nikic

Description

@nikic

04fb9b7 fixes a miscompile in AArch64 debug builds using GlobalISel, where previously nonsensical mrs NZCV instructions were inserted (originally reported at rust-lang/rust#92786).

The patch does not apply cleanly to 13.x, I have rebased it here: nikic@1715dad Notably the test output in the truncating_f8 test is slightly different, there are three COPYs on 13.x rather than two. I'm not sure whether that is okay or indicative of a problem (maybe @aemerson can confirm).

If it's too late for the 13.0.1 release, we'll carry this patch on the rustc side.

Activity

added this to the LLVM 13.0.1 release milestone on Jan 12, 2022
llvmbot

llvmbot commented on Jan 14, 2022

@llvmbot
Member

@llvm/issue-subscribers-backend-AArch64

tstellar

tstellar commented on Jan 14, 2022

@tstellar
Collaborator

@TNorthover What do you think about this?

TNorthover

TNorthover commented on Jan 19, 2022

@TNorthover
Contributor

Yep, I think this one is good too.

nikic

nikic commented on Jan 25, 2022

@nikic
ContributorAuthor

Removing this as a backport candidate -- this failed rustc aarch64 testing with:

B0 = COPY H0
unimplemented reg-to-reg copy

So probably this patch has some other dependency on the main branch, but I haven't figure out what it is yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @tstellar@nikic@TNorthover@EugeneZelenko@llvmbot

      Issue actions

        Cherry-pick AArch64/GlobalISel fp copy fix · Issue #53162 · llvm/llvm-project